[Webkit-unassigned] [Bug 38564] Caret keeps blinking during forward-delete

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38564





--- Comment #3 from Darin Adler <darin at apple.com>  2011-08-31 16:51:55 PST ---
(From update of attachment 105823)
View in context: https://bugs.webkit.org/attachment.cgi?id=105823&action=review

>> Source/WebCore/editing/TypingCommand.h:73
>> +    bool shouldStopCaretBlinking() const { return true; }
> 
> This override could, and should, be private rather than public. It would be a programming mistake to call this on a TypingCommand*.

Also, WebKit coding style is to always explicitly say virtual on a virtual function override like this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.