[Webkit-unassigned] [Bug 67302] Add pass-throughs for NPObject/v8::Value marshalling to WebBindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67302





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-31 16:47:02 PST ---
(From update of attachment 105847)
View in context: https://bugs.webkit.org/attachment.cgi?id=105847&action=review

> Source/WebKit/chromium/public/WebBindings.h:167
> +    // Conversion utilities to/from V8 native objects and NPObject wrappers.

nit: s/NPObject/NPVariant/

> Source/WebKit/chromium/src/WebBindings.cpp:339
> +    WebCore::convertV8ObjectToNPVariant(object, root, result);

nit: note the 'using namespace WebCore' at the top of this file.  you can drop the WebCore:: prefixes.

> Source/WebKit/chromium/src/WebBindings.cpp:346
> +        if (object->_class != WebCore::npScriptObjectClass)

ditto

> Source/WebKit/chromium/src/WebBindings.cpp:353
> +    return WebCore::convertNPVariantToV8Object(variant, static_cast<NPObject*>(0));

is the static_cast necessary?  can you just get by passing 0 or nullptr?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.