[Webkit-unassigned] [Bug 67302] Add pass-throughs for NPObject/v8::Value marshalling to WebBindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67302





--- Comment #3 from Greg Billock <gbillock at google.com>  2011-08-31 15:37:51 PST ---
(From update of attachment 105796)
View in context: https://bugs.webkit.org/attachment.cgi?id=105796&action=review

>> Source/WebKit/chromium/public/WebBindings.h:169
>> +    WEBKIT_EXPORT static v8::Handle<v8::Value> convertNPVariantToV8Object(const NPVariant*);
> 
> This returns a v8::Value, not a v8::Object.  Maybe the name should be convertNPVariantToV8Value?  or, maybe we could even use short-cuts like:
> 
>   toV8Value
>   toNPVariant

I'm happy to switch to that. I was basically copying the V8NPUtils names exactly to make the wrapping very clear. It looked like other WebBindings and Web* APIs tended to do that, although not universally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.