[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297





--- Comment #79 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-08-31 15:25:39 PST ---
(From update of attachment 105836)
View in context: https://bugs.webkit.org/attachment.cgi?id=105836&action=review

> Source/WebKit2/ChangeLog:9
> +        With current patch Web Inspector page using qdesktopwebview only.

QDesktopWebView and not qdesktopwebview.
Add something like "We create a QDesktopWebView that render the inspector, and a QSGView to display it", since that's what the patch does.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:68
> +    if (m_view) {
> +        m_view->close();
> +        m_view.clear();
> +    }

m_view.clear() should be enough, no need for the null check and close IIRC.

> Tools/ChangeLog:15
> +        1. "Enable Developer Extras" available, not selected
> +           "Toggle Web Inspector" unavailable, not selected
> +        2. "Enable Developer Extras" available, selected
> +            "Toggle Web Inspector" available, not selected
> +        3. "Enable Developer Extras" unavailable, selected
> +           "Toggle Web Inspector" available, selected

No need for this. The next two lines say enough.

> Tools/ChangeLog:16
> +        User can start Web Inspector only after "Enable Developer Extras" was selected

Period at end of sentence.

> Tools/ChangeLog:17
> +        User can't disable "Enable Developer Extras" when Web Inspector is running

Period at end of sentence.

> Tools/MiniBrowser/qt/BrowserWindow.h:59
> +    void enteredWebInspectorMode(bool on);
> +    void enteredDeveloperExtrasMode(bool on);

This is a bit strange, but I guess it's consistent with enteredFullScreenMode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.