[Webkit-unassigned] [Bug 67308] [Qt] TouchWebView crashes with segmentation fault

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67308


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105832|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Benjamin Poulain <benjamin at webkit.org>  2011-08-31 14:57:12 PST ---
(From update of attachment 105832)
View in context: https://bugs.webkit.org/attachment.cgi?id=105832&action=review

Patch looks good but the changelog and the tests can be made better.

> Source/WebKit2/ChangeLog:15
> +        If you instantiate TouchWebView element with height and width in a qml file and
> +        load a url it crashes. During first round
> +        updateViewportConstraints has non-zero width and 0 as height. As a result availableSize
> +        is set to (width,0). Height gets set by subsequent call to setHeight. However, the
> +        ASSERT in computeViewportAttributes expects non-zero values for both height and width.
> +        setWidth and setHeight are called sequentially therefore it can happen that computeViewportAttributes
> +        was called with a size like (width, 0) breaking the assumption of the function that the size is valid. The patch makes sure we compute the viewport when both height and width are valid.
> +

Please rewrap this and rephrase it a bit clearer.

"If you instantiate TouchWebView element with height and width in a qml file and load a url it crashes" -> QTouchWebView can asserts when loading a page if the viewport does not have a valid geometry.

"setWidth and setHeight" -> The functions setWidth() and setHeight() so that sentence is a bit easier to read.

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:8
> +    height: 600
> +    width: 400

0, 0???

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.