[Webkit-unassigned] [Bug 67299] Add Android's platform specification and atomic functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67299


Peter Beverloo <peter at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |66689




--- Comment #4 from Peter Beverloo <peter at chromium.org>  2011-08-31 11:41:50 PST ---
(In reply to comment #2)
> (From update of attachment 105790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105790&action=review
> 
> LGTM, but I'd like to get somebody else to take a look to double-check the change to Platform.h, perhaps Maciej?

Ok, thanks.

> 
> Also, shouldn't this bug block Bug 66689?

Yes, you're right. I've added the bug, but won't remove the main one as that'll unnecessarily mail all cc'ed people again.

> 
> > Source/JavaScriptCore/wtf/Atomics.h:109
> > +inline int atomicDecrement(int volatile* addend) { return __atomic_dec(addend); }
> 
> So __atomic_inc/dec() are functionally identical to android_atomic_inc/dec() removed in r94191, but are in the NDK, right?

Yes.

> 
> > Source/JavaScriptCore/wtf/Platform.h:306
> > +/* OS(ANDRO67299ID) - Android */
> 
> ??!!

Ugh, fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.