[Webkit-unassigned] [Bug 66681] Need API for getting surrounding text from webkit in chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 31 11:41:13 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66681





--- Comment #23 from Peng Huang <penghuang at chromium.org>  2011-08-31 11:41:13 PST ---
(In reply to comment #16)
> (From update of attachment 105686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105686&action=review
> 
> > Source/WebCore/editing/FrameSelection.cpp:1887
> > +bool FrameSelection::getSurroundingText(String& text, size_t& focus, size_t& anchor) const
> 
> It seems like the function name should reflect the fact it only obtains text in the content editable area.  Also, I'd expect the return value of a function named get...Text to be a string.

How about getSurrounding() or getSurroundingTextAndSelection()? Or do you have some better suggestions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list