[Webkit-unassigned] [Bug 67299] Add Android's platform specification and atomic functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67299





--- Comment #2 from Steve Block <steveblock at google.com>  2011-08-31 10:59:37 PST ---
(From update of attachment 105790)
View in context: https://bugs.webkit.org/attachment.cgi?id=105790&action=review

LGTM, but I'd like to get somebody else to take a look to double-check the change to Platform.h, perhaps Maciej?

Also, shouldn't this bug block Bug 66689?

> Source/JavaScriptCore/wtf/Atomics.h:109
> +inline int atomicDecrement(int volatile* addend) { return __atomic_dec(addend); }

So __atomic_inc/dec() are functionally identical to android_atomic_inc/dec() removed in r94191, but are in the NDK, right?

> Source/JavaScriptCore/wtf/Platform.h:306
> +/* OS(ANDRO67299ID) - Android */

??!!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.