[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297





--- Comment #73 from Alexis Menard <alexis.menard at openbossa.org>  2011-08-31 10:09:20 PST ---
(In reply to comment #71)
> (In reply to comment #70)
> > (In reply to comment #68)
> > > (From update of attachment 105726 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=105726&action=review
> > > 
> > > > Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:80
> > > > +    m_view->setWindowTitle(QObject::tr("Web Inspector - ") + QObject::tr(url.utf8().data()));
> > > 
> > > Problem here as we said earlier, you don't translate URLs.
> > 
> > Can you, please, explain how translate URL. 
> 
> QObject::tr will trigger the translation system, you don't need to do that as there is no need to translate an URL, just like Andreas said. It didn't bug/warn/surprised you when you typed on the keyboard "Can you, please, explain how translate URL."? -> this sentence is totally odd.
> 
> No translation of URLs, or should I say : "please remove the QObject::tr() call of QObject::tr(url.utf8().data())) and replace it by QObject::tr(Web Inspector - %1).arg(url.utf8().data()) as Andreas suggested".

And btw my head is not a compiler, check that it compiles + there is no better way than url.utf8().data(). 

> 
> Seriously...
> 
> > 
> > I guess you check my comments.
> > This methods updates Web Inspector title. And if you compare results one can see
> > in Web Inspector safari and Web Inspector qt, results are the same.

So url is the string "Qt" I'm confused.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.