[Webkit-unassigned] [Bug 66756] Implement an Event constructor in V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66756





--- Comment #36 from Dominic Cooney <dominicc at chromium.org>  2011-08-31 09:45:05 PST ---
(From update of attachment 105756)
View in context: https://bugs.webkit.org/attachment.cgi?id=105756&action=review

Only minor formatting comments remain.

> Source/WebCore/ChangeLog:19
> +        (WebCore::OptionsObject::getKeyValue): Returns a value corresnponding to a given key.

nit: corresponding

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:37
> +

Why is this blank line still here? :P

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:85
> +     \

Did Sam’s patch indent the equivalent line one space less? What does check-webkit-style say?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.