[Webkit-unassigned] [Bug 66838] Extract reference links from reftest test file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66838





--- Comment #4 from Ai Makabi <makabi at google.com>  2011-08-30 22:45:28 PST ---
(From update of attachment 105129)
Thank you for the review.

View in context: https://bugs.webkit.org/attachment.cgi?id=105129&action=review

>> Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py:42
>> +            if attrs["rel"] == "match":
> 
> I think this will raise an error (KeyError) if the input html contains <link> without rel attribute.

Done.

>> Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py:48
>> +def get_reference_link(html):
> 
> Could you write a docstring for this? I think it should explain the argument (is this a string or a file?) and the return value (a tuple)

Done.

>> Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:28
>> +import extract_reference_link
> 
> from webkitpy.layout_tests.reftests import extract_reference_link ?
> 
> I guess this won't pass ./Tools/Scripts/test-webkit-scripts , but I'm not sure.

Done.

>> Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:29
>> +
> 
> BTW, we usually put imports in alphabetical order.

Done.

>> Tools/Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:61
>> +                         ["red-box-notref.xht", "red-box-notref.xht"])
> 
> It might be nice if we have another test function which exercises error cases. For example, I'd test <link> without rel, unclosed <link> (what will happen if the input is broken as an HTML...?), etc.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.