[Webkit-unassigned] [Bug 66536] Implement Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66536


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105706|review?                     |review+
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2011-08-30 22:24:43 PST ---
(From update of attachment 105706)
View in context: https://bugs.webkit.org/attachment.cgi?id=105706&action=review

This looks great.  We'll need to do something similar to CodeGeneratorJS if we want to use this in more than a handful of IDL files.

Thanks for writing this patch.

> Source/WebCore/bindings/scripts/IDLParser.pm:158
> +        if ($str =~ /^\s*=/) {
> +            # Parse '=' value | '=' value ','
> +            $str =~ s/^\s*=//;
> +            if ($str =~ /^\s*([^,]*),?/) {

Perl makes me sad face.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.