[Webkit-unassigned] [Bug 67251] New: Chromium defines its own toHTMLInputElement in DOMUtilitiesPrivate.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67251

           Summary: Chromium defines its own toHTMLInputElement in
                    DOMUtilitiesPrivate.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, fishd at chromium.org,
                    tony at chromium.org, tkent at chromium.org,
                    morrita at google.com


Apparently chromium defines its own toHTMLInputElement in DOMUtilitiesPrivate.h, and this caused compilation to fail after I landed http://trac.webkit.org/changeset/94142.

Error messages:
Source/WebKit/chromium/src/EditorClientImpl.cpp: In member function ‘virtual void WebKit::EditorClientImpl::textFieldDidEndEditing(WebCore::Element*)’:
Source/WebKit/chromium/src/EditorClientImpl.cpp:657: error: call of overloaded ‘toHTMLInputElement(WebCore::Element*&)’ is ambiguous
Source/WebKit/chromium/src/DOMUtilitiesPrivate.h:49: note: candidates are: WebCore::HTMLInputElement* WebKit::toHTMLInputElement(WebCore::Node*)
Source/WebCore/html/HTMLInputElement.h:359: note:                 WebCore::HTMLInputElement* WebCore::toHTMLInputElement(WebCore::Node*)

Source/WebKit/chromium/src/EditorClientImpl.cpp: In member function ‘virtual bool WebKit::EditorClientImpl::doTextFieldCommandFromEvent(WebCore::Element*, WebCore::KeyboardEvent*)’:
Source/WebKit/chromium/src/EditorClientImpl.cpp:679: error: call of overloaded ‘toHTMLInputElement(WebCore::Element*&)’ is ambiguous
Source/WebKit/chromium/src/DOMUtilitiesPrivate.h:49: note: candidates are: WebCore::HTMLInputElement* WebKit::toHTMLInputElement(WebCore::Node*)

It's very error-prone for each port to define utility functions that act on WebCore objects like this.  At least, we shouldn't have WebCore::toHTMLInputElement and WebKit::toHTMLInputElement that have two different behaviors (the latter returns null when the node's tagName isn't inputTag).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.