[Webkit-unassigned] [Bug 66756] Implement an Event constructor in V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66756





--- Comment #27 from Dominic Cooney <dominicc at chromium.org>  2011-08-30 17:23:10 PST ---
(From update of attachment 105720)
View in context: https://bugs.webkit.org/attachment.cgi?id=105720&action=review

I love it.

> LayoutTests/ChangeLog:9
> +        since the Event consructor is now available in V8.

Spelling: constructor

You probably don’t need this paragraph anyway. Just say "unskip fast/events/constructors/event-constructors.html" in on the comment line for test_expectations.

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:37
> +

Delete this blank line.

> Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp:58
> +    if (AllowAllocation::current())

Yes, this looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.