[Webkit-unassigned] [Bug 53055] REGRESSION: Rendering artifacts on a rotated, pattern filled shape

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53055





--- Comment #46 from Tim Horton <timothy_horton at apple.com>  2011-08-30 16:54:41 PST ---
(In reply to comment #44)
> (From update of attachment 105719 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105719&action=review
> 
> > Source/WebCore/platform/graphics/cg/PatternCG.cpp:68
> > +    // If we're repeating in both directions, we can use image-backed patterns
> > +    // instead of custom patterns, and fix tiling-edge pixel cracks
> 
> In WebKit coding style we use a period at the end of a sentence like this one. I would say “avoid” rather than “fix”.
> 
> > Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:120
> > +        // Ignore 2D rotation, as it doesn't affect the size of the tile
> 
> Again, periods at the ends of comments, even ones that aren’t full sentences.
> 
> > Source/WebCore/rendering/svg/SVGImageBufferTools.cpp:128
> > +    // FIXME67242: Don't round-trip through TransformationMatrix.
> 
> This is not our usual format. Ramming the bug number up against FIXME is not how we do it.
> 
> I’m not sure this really needs a FIXME. Sure, it would be more elegant, but what’s the big deal? Probably overkill to include the comment. Unless you said in the comment *why* it needs to be fixed.

I clearly need a trip back to the style page.

I've made these changes locally; I don't see any reason to clog up the EWS bots since they don't change any code, so I'll keep them here.

I agree about the FIXME, now that you mention it -- it's not actually *broken* (just a very minor performance difference), so the bug should suffice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.