[Webkit-unassigned] [Bug 53055] REGRESSION: Rendering artifacts on a rotated, pattern filled shape

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53055





--- Comment #42 from Darin Adler <darin at apple.com>  2011-08-30 16:32:13 PST ---
(From update of attachment 105715)
View in context: https://bugs.webkit.org/attachment.cgi?id=105715&action=review

> Source/WebCore/platform/graphics/cg/PatternCG.cpp:73
> +    // The pattern will release the tile when it's done rendering in patternReleaseCallback
> +    tileImage()->ref();

Why does this need to be moved?

> Source/WebCore/platform/graphics/cg/PatternCG.cpp:85
> -        kCGPatternTilingConstantSpacing, TRUE, &patternCallbacks);
> +                           kCGPatternTilingConstantSpacing, TRUE, &patternCallbacks);

This change should not be made. The old code conforms to WebKit coding standards and the new indenting does not.

> Source/WebCore/rendering/svg/SVGImageBufferTools.h:45
> +    static void clearAffineTransform2DRotation(AffineTransform&);

I’m not sure this function needs the word Affine or even the word Transform in its name, since this is C++ with overloading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.