[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 30 11:16:10 PDT 2011


--- Comment #62 from Genisim <genisim at yahoo.com>  2011-08-30 11:16:10 PST ---
(In reply to comment #61)
> (In reply to comment #60)
> > Noam,
> > 
> > Please review my comments.
> > 
> > I'll replace vars (remove m_ prefix)
> > 
> > Please explain why is so principal to use OwnPtr, what benefits one will get from this change
> OwnPtr will delete the object it holds for you whenever the pointer dies. It's a nice practice to use it, just as the WebKit code base is doing.
> > 
> > Please review again submitted patch and try send me requests to ,hope, all unacceptable elements in patch
> > 
> > thanks a lot

Hi Alexis,

using smart pointer OwnPtr is a good practice. Agreed. I'm not familiar good enough with OwnPtr. Can you please provide simple example for OwnPtr usage.

According to WebInspector code I'll set follow requirements for this simple example:
  1. OwnPtr must be initialize by NULL (no value) in WebInspectorProxy constructor
  2. One will assign value at WebInspector creating time
  3. OwnPtr will be released at WebInspector close time  


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list