[Webkit-unassigned] [Bug 67192] API to set initial focus in gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67192


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105619|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2011-08-30 09:29:57 PST ---
(From update of attachment 105619)
View in context: https://bugs.webkit.org/attachment.cgi?id=105619&action=review

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4026
> +void webkit_web_view_set_initial_focus(WebKitWebView* webView, gboolean forward)

This needs API documentation and a unit test.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4027
> +{

Why no g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4030
> +    Page* page = core(webView);
> +
> +    if (page && page->focusController()) {

Please use an early return here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.