[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #38 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2011-08-30 04:42:44 PST ---
(From update of attachment 105367)
View in context: https://bugs.webkit.org/attachment.cgi?id=105367&action=review

>> Source/WebCore/plugins/efl/PluginPackageEfl.cpp:121
>> +    }
> 
> Small nit: you could ditch m_isLoaded and just use m_loadCount instead.

There can be situation that m_isLoaded is set, but m_loadCount is not incremented when module is opened, but symbols(NP_Initialize, and NP_Shutdown) can't be taken. Same implementation in Gtk.

>> Source/WebCore/plugins/efl/PluginViewEfl.cpp:106
>> +            || event->type() == eventNames().mouseoverEvent) {
> 
> Minor nit: wouldn't a switch() statement be better here?

event->type() is type of AtomicString, so can't use switch here

>> Source/WebCore/plugins/efl/PluginViewEfl.cpp:236
>> +        *result = NPERR_NO_ERROR;
> 
> Are value and result guaranteed to be non-null?

result is guaranteed, but value is not checked in any port. It looks that in this matter webkit trusts plugins. Also type of value is taken from type of NPNVariable which is possibly dangerous(casting from void* to different types of returned value)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.