[Webkit-unassigned] [Bug 66925] [WebSocket] WebSocket::close didn't handle code and reason arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66925


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105340|review?                     |review-
               Flag|                            |




--- Comment #10 from Kent Tamura <tkent at chromium.org>  2011-08-30 01:25:51 PST ---
(From update of attachment 105340)
View in context: https://bugs.webkit.org/attachment.cgi?id=105340&action=review

> LayoutTests/http/tests/websocket/tests/hybi/close.html:108
> +    // TODO(toyoshim): unpaired surrogates throw SYNTAX_ERR

TODO(name) is not a WebKit style.

> LayoutTests/http/tests/websocket/tests/hybi/close_wsh.py:56
> +
> +
> +# vi:sts=4 sw=4 et

Should remove such editor-specific annotation.

> LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:120
> +            //shouldBeTrue("exceptionProto === DOMException.prototype");

should remove unused code.

> LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close.js:160
> +            //shouldBeTrue("exceptionProto === DOMException.prototype");

ditto.

> Source/WebCore/bindings/js/JSWebSocketCustom.cpp:93
> +    int argumentCount = static_cast<int>(exec->argumentCount());

Why don't you use unsigned or size_t for argumentCount?

> Source/WebCore/websockets/WebSocketChannel.cpp:737
> +                startClosingHandshake(0, "");

What does "0" mean?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.