[Webkit-unassigned] [Bug 67009] Clicking causes dirty rects that may be unnecessary; this affects future optimizations.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67009


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105520|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2011-08-29 16:17:59 PST ---
(From update of attachment 105520)
View in context: https://bugs.webkit.org/attachment.cgi?id=105520&action=review

> Source/WebCore/ChangeLog:10
> +        Tests N/A

It’s not true that tests are not applicable to a change like this. We do want to come up with a way to test a change like this.

> Source/WebCore/editing/FrameSelection.cpp:1222
> -    m_absoluteCaretRepaintBounds = caretRepaintRect(m_selection.start().deprecatedNode());
> +    m_absoluteCaretRepaintBounds = m_selection.isNone() ? caretRepaintRect(m_selection.start().deprecatedNode()) : LayoutRect();

This change means that when you are changing the selection to none, we won’t erase the old caret. That’s not correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.