[Webkit-unassigned] [Bug 67155] [Qt] QDesktopWebView url property test missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67155


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105523|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-08-29 14:52:18 PST ---
(From update of attachment 105523)
View in context: https://bugs.webkit.org/attachment.cgi?id=105523&action=review

> Source/WebKit2/ChangeLog:8
> +        Added qml test case to check url property

Period at end of sentence please.

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:30
> +            var tstUrl = Qt.resolvedUrl("../common/test1.html")
> +            webView.load(tstUrl)
> +            spy.wait()
> +            compare(webView.url, tstUrl)
> +        }

This doesn't test anything. Please test that the page actually loaded, e.g. by testing that the title has changed (like the test above it).
Also, use testUrl instead of tstUrl. Abbvs don't smplfy reading the code :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.