[Webkit-unassigned] [Bug 67007] r93794 results in ruby tests causing assertion failure in RenderBlock.cpp

Mon Aug 29 13:57:48 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=67007

Abhishek Arya <inferno at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Security                    |WebKit
            Version|525.x (Nightly build)       |528+ (Nightly build)
          Component|Security                    |Layout and Rendering
         AssignedTo|webkit-security-unassigned@ |webkit-unassigned at lists.web
                   |lists.webkit.org            |kit.org
              Group|Security-Sensitive          |

--- Comment #7 from Abhishek Arya <inferno at chromium.org>  2011-08-29 13:57:47 PST ---
Ok, so we don't have any bug here and dont need the fix in c#5. Roland, i will leave this bug to you to fix the assert and add some more rendertree tests.

1. RenderBlock beforeChild calculation is fixed with my fix in r93794.
<html>
<body style="font: 1em/1 Ahem, sans-serif;">
<style type="text/css">
ruby {
    display: block;
}
ruby::after{
    content: "AFTER";
    display: table-cell;
}
</style>
<ruby id="test"></ruby>
<script>
    document.body.offsetTop;

    var ruby = document.getElementById('test');
    ruby.appendChild(document.createTextNode("CONTENT"));
</script>
</body>
</html>

2. RenderInline beforeChild calculation already exists,
void RenderInline::addChildIgnoringContinuation(RenderObject* newChild, RenderObject* beforeChild)
{
    // Make sure we don't append things after :after-generated content if we have it.
    if (!beforeChild && isAfterContent(lastChild()))
        beforeChild = lastChild();

<html>
<body style="font: 1em/1 Ahem, sans-serif;">
<style type="text/css">
ruby::after{
    content: "AFTER";
}
</style>
<ruby id="test"></ruby>
<script>
    document.body.offsetTop;

    var ruby = document.getElementById('test');
    ruby.appendChild(document.createTextNode("CONTENT"));
</script>
</body>
</html>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.