[Webkit-unassigned] [Bug 66969] Chromium: Add a layer for rubber-band overhang painting to the hardware path.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66969





--- Comment #2 from Adrienne Walker <enne at google.com>  2011-08-29 13:53:21 PST ---
(From update of attachment 105229)
View in context: https://bugs.webkit.org/attachment.cgi?id=105229&action=review

Despite being titled as such, this doesn't look like a Chromium-specific patch.  I think you are going to either need to add some sort of setting for this or otherwise make it conditional.

Does rubber-banding work out of the box on other hardware accelerated ports?

> Source/WebCore/platform/ScrollView.cpp:1037
> +#if USE(ACCELERATED_COMPOSITING)
> +    if (!layerForScrollCorner())
> +        calculateAndPaintOverhangAreas(context, rect);

Why do you need the scroll corner layer check here?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:960
> +        m_layerForOverhangAreas->setSize(frameView->frameRect().size());

Maybe I misunderstand how these layers are supposed to work, but I would expect overhang layers to be related to the size and position of horizontalOverhangRect and verticalOverhangRect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.