[Webkit-unassigned] [Bug 67078] new-run-webkit-tests chromium port fails a windows test in test-webkitpy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 29 12:29:23 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67078





--- Comment #5 from Shawn Singh <shawnsingh at chromium.org>  2011-08-29 12:29:23 PST ---
Right, I should have explained.

In my opinion there already is an appropriate test for this patch.   It is the unit test code for NWRT itself, which can be run by Tools/Scripts/test-webkitpy.  The specific test that was failing is test_diff_image() in Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py.

This patch fixes a previous fix that I submitted for
https://bugs.webkit.org/show_bug.cgi?id=47240

that patch did fail (as it should have) the test-webkitpy script, so I feel the existing tests are appropriate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list