[Webkit-unassigned] [Bug 65896] [Qt] Need spin-button implementation

Mon Aug 29 04:21:03 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65896

Balazs Kelemen <kbalazs at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kbalazs at webkit.org

--- Comment #21 from Balazs Kelemen <kbalazs at webkit.org>  2011-08-29 04:21:03 PST ---

(In reply to comment #19)
> Hey Ossy, all fast/forms tests passed on my machine faithfully, there were no failures or flaky results.  Of course I run the tests before I submit; but thanks for those kind links that I already read a year ago ;)
> 
> I'll review further when I get in to my office why they're green for me but not for you.  No sense in a roll out.  I was also not aware of the minimal build wrt spinbox so I apologize for that, I'll get a min build of Qt here to avoid that going forward.

Thank you for taking care of that. However I don't understand your (I mean the Trolls :) ) policy of rollouting. The bot is valuable if it is green almost all the time. What is the benefit of not rolling out smg that makes it red? It doesn't depend on the kind of the failure. I think even a good patch that only needs rebaselined results should be rolled out if nobody is able to fix the redness immediately. It's not a big deal to reland a patch with updated results. Actually it is not really more tiring than just land the new results, is it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.