[Webkit-unassigned] [Bug 35299] [Gtk] mousemove event always has metaKey == true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35299


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105450|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2011-08-28 14:32:16 PST ---
(From update of attachment 105450)
View in context: https://bugs.webkit.org/attachment.cgi?id=105450&action=review

> Source/WebCore/ChangeLog:5
> +        GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
> +        the meta key state. Use GDK_META_MASK instead.
> +        https://bugs.webkit.org/show_bug.cgi?id=35299

The format here should be:

bug title
bug url

review line

description

> Source/WebCore/ChangeLog:12
> +        Test: manual-tests/special-key-states-for-mouse-events.html
> +
> +        * manual-tests/special-key-states-for-mouse-events.html: Added a manual
> +        test which shows the status of special keys for different mouse events.

As long as you are updating EventSender, it makes sense to make an automated test.

> Tools/ChangeLog:7
> +        GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
> +        the meta key state. Use GDK_META_MASK instead.
> +        https://bugs.webkit.org/show_bug.cgi?id=35299
> +
> +        Reviewed by NOBODY (OOPS!).

See above.

> Tools/DumpRenderTree/gtk/EventSender.cpp:278
> -    // Currently the metaKey as defined in WebCore/platform/gtk/MouseEventGtk.cpp
> -    // is GDK_MOD2_MASK. This code must be kept in sync with that file.
>      else if (JSStringIsEqualToUTF8CString(string, "metaKey"))

Why remove this comment instead of updating it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.