[Webkit-unassigned] [Bug 67034] Teach scripts how to handle the building env. for the Chromium port on OS(ANDROID)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67034





--- Comment #2 from Peter Beverloo <peter at chromium.org>  2011-08-27 10:54:05 PST ---
Thank you for the review!

(In reply to comment #1)
> (From update of attachment 105355 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105355&action=review
> 
> > Tools/Scripts/update-webkit-chromium:63
> > +    # TODO(beverloo) Add code to automatically download the NDK
> 
> TODO(beverloo) => FIXME
> ^^^ WebKit's style is to use FIXME rather than TODO.

Done.

> > Tools/Scripts/update-webkit-chromium:79
> > +push @gclientArgs, "--deps=unix,android" if isChromiumAndroid();
> 
> We grab the unix deps, even on Mac?

Yes, we're building for Android, which is based on Linux (gclient uses "unix" instead of "linux"). 

> > Tools/Scripts/webkitdirs.pm:1912
> > +        my $ndkBaseDir = getcwd() . "/Source/WebKit/chromium/third_party/android-ndk-r6";
> 
> You sure getcwd() is right here?  I would have expected sourceDir().  Please make sure this works when run from outside the root before landing.

build-webkit (just like update-webkit and update-webkit-chrmoium) chdir as one of the first steps in their execution. Since sourceDir() ensures this, however, I've updated the line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.