[Webkit-unassigned] [Bug 66661] Replace some usages of Vector<UChar> to StringBuilder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66661





--- Comment #12 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-08-26 20:36:03 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> 
> Thanks for the advice about how to better split up the patch, Darin. Xianzhu, please let me know if you'd like any help with the smaller patches.
>

I'll file some sub-bugs to track the smaller patches and take some of them.

> 
> In addition to thinking carefully about overflow when writing the code, it seems like unit tests would be helpful to make sure everything is correct. I couldn't find documentation on this, but it looks like:
> 
> 1. Tests for these classes Tools/TestWebKitAPI/Tests/WTF/
> 2. You can run the tests using the script Tools/Scripts/run-api-tests
> 
> Is that correct?

I've included a unit test in the patch, but only for chromium (Source/WebKit/tests/StringBuilderTest.cpp).
I think it should be moved to under Tools/TestWebKitAPI/Tests/WTF.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.