[Webkit-unassigned] [Bug 67051] Fix assertion when running debug build of Mac platform DRT.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67051


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105387|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2011-08-26 14:04:52 PST ---
(From update of attachment 105387)
View in context: https://bugs.webkit.org/attachment.cgi?id=105387&action=review

I'm confused. Is there something special that one needs to do to hit this assertion? Mac debug build is how I'm running DRT, and I haven't seen it fire.

> Source/WebCore/bindings/js/ScriptController.cpp:193
>          windowShell->window()->willRemoveFromWindowShell();
> -        windowShell->setWindow(m_frame->domWindow());
> +        if (m_frame->domWindow() != windowShell->impl())
> +            windowShell->setWindow(m_frame->domWindow());

This can not be quite correct, because we tell JSDOMWindow that it will be removed from window shell, but don't fulfill the promise.

I would need to see how the assertion fails (and then probably consult with Geoff) to suggest a better approach, but it's likely that we should avoid calling clearWindowShell altogether.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.