[Webkit-unassigned] [Bug 67035] Modify the build bot master's script to pass --chromium-android where appropriate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67035


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105356|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #1 from Adam Barth <abarth at webkit.org>  2011-08-26 12:17:44 PST ---
(From update of attachment 105356)
View in context: https://bugs.webkit.org/attachment.cgi?id=105356&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:91
> +def appendCustomBuildFlags(step, platform, fullPlatform=""):

I see.  The issue here is that we're cross-compiling.  Maybe rather than "fullPlatform" we should say target_os ?

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:92
> +    if fullPlatform == "chromium-android":

This this becomes platform == "chromium" && target_os == "android".

That will generalize better if we want to support other sorts of cross compiling (e.g., building on Linux but targeting Mac).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.