[Webkit-unassigned] [Bug 65896] [Qt] Need spin-button implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 26 05:33:03 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=65896
--- Comment #10 from Jarred Nicholls <jarred at sencha.com> 2011-08-26 05:33:03 PST ---
(In reply to comment #5)
> (From update of attachment 105306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105306&action=review
>
> Any screenshot of how this looks?
Attached a few.
>
> > Source/WebCore/platform/qt/RenderThemeQt.cpp:1075
> > + int width = ScrollbarTheme::nativeTheme()->scrollbarThickness();
>
> So this will mean that on mobile platforms such as the N9 where we are not showing scrollbars, the width will be 0. Not good.
>
Yeah I was aware of that, and was counting on someone from Nokia to clarify what value (if any) should be given here for QT_MOBILE_THEME, and if we need to add to QtMobileWebTheme's drawComplexControl. Or, do we keep it the status quo.
> > Source/WebCore/platform/qt/RenderThemeQt.cpp:1080
> > +bool RenderThemeQt::paintInnerSpinButton(RenderObject* o, const PaintInfo& pi, const IntRect& r)
>
> We try to write out things like r to rect etc. o is often used though due to 'object' being quite overloaded.
>
Okay, I agree and I typically use clearer variable names, but more importantly I keep consistent w/ existing code. If you look around, almost every other template method in RenderThemeQt uses 1 char names. I hate it, so I'm happy to revise ;)
> > Source/WebCore/platform/qt/RenderThemeQt.cpp:1109
> > + // render mini aqua spin buttons
>
> We use proper sentences. (ie starts with capital, ends with punctuation mark)
Cool, I'll re-write this.
Thanks!
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list