[Webkit-unassigned] [Bug 44505] [EFL] Missing plugins support for efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44505





--- Comment #35 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-08-26 02:51:53 PST ---
(From update of attachment 105018)
View in context: https://bugs.webkit.org/attachment.cgi?id=105018&action=review

It looks this patch is a little huge. Can you split this patch into smaller ones ?

> Source/JavaScriptCore/ChangeLog:7
> +

There is no description.

> Source/WebCore/CMakeListsEfl.txt:13
> +  "${WEBCORE_DIR}/plugins/efl"

Please adhere alphabetical order.

> Source/WebCore/CMakeListsEfl.txt:84
> +    plugins/PluginView.cpp

Please add an empty line to here.

> Source/WebCore/ChangeLog:8
> +        Basic functionality of plugins for efl port

Missing "." at the end of line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.