[Webkit-unassigned] [Bug 65896] [Qt] Need spin-button implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65896





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-08-26 01:17:37 PST ---
(From update of attachment 105306)
View in context: https://bugs.webkit.org/attachment.cgi?id=105306&action=review

Any screenshot of how this looks?

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1075
> +    int width = ScrollbarTheme::nativeTheme()->scrollbarThickness();

So this will mean that on mobile platforms such as the N9 where we are not showing scrollbars, the width will be 0. Not good.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1080
> +bool RenderThemeQt::paintInnerSpinButton(RenderObject* o, const PaintInfo& pi, const IntRect& r)

We try to write out things like r to rect etc. o is often used though due to 'object' being quite overloaded.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1109
> +        // render mini aqua spin buttons

We use proper sentences. (ie starts with capital, ends with punctuation mark)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.