[Webkit-unassigned] [Bug 67015] REGRESSION(r93390): Invalid maxlength attribute causes input to allow no text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67015


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105302|review?                     |review-
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-08-25 22:27:47 PST ---
(From update of attachment 105302)
View in context: https://bugs.webkit.org/attachment.cgi?id=105302&action=review

> LayoutTests/ChangeLog:3
> +        Empty or invalid maxlength of an input tag should be ignored.

Please prepend "REGRESSION(r93390): " to the summary.  It's a WebKit idiom for a regression.

> Source/WebCore/ChangeLog:3
> +        Empty or invalid maxlength of an input tag should be ignored.

ditto.

> Source/WebCore/html/HTMLInputElement.cpp:1926
> +    bool ok = true;
> +    int maxLength = attribute->isNull() ? maximumLength : attribute->value().toInt(&ok);
> +    if (!ok || maxLength < 0 || maxLength > maximumLength)

Please use parseHTMLInteger() in WebCore/html/parser/HTMLParserIdioms.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.