[Webkit-unassigned] [Bug 67006] [chromium] Add MockWebGraphicsContext3D, for compositor unit testing

Thu Aug 25 19:09:32 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=67006

--- Comment #3 from Kenneth Russell <kbr at google.com>  2011-08-25 19:09:32 PST ---
(In reply to comment #2)
> (From update of attachment 105288 [details])
> I have a high level question for @kbr, though, which is whether this is the right layer to hook at. I just can't make my mind up, personally.
> 
> Clearly, its the only place we can hook right now because everything higher is non-virtual.
> 
> However, this means that all our testing becomes specific to the Chromium port.
> 
> Is this OK? I guess some of this ties back to me not understanding WebKits' overal position on unit tests...

I think this is fine for the time being. There's been discussion in recent months about settling on a unit testing framework for the overall WebKit project -- see https://lists.webkit.org/pipermail/webkit-dev/2011-April/016510.html -- but so far everyone's been too busy to push it forward. There was some consensus at the last WebKit meeting in April that the project would try to standardize on gtest, which is full featured and well maintained, so adding a gtest-compatible mock and tests sounds good even if they're currently Chromium specific. They could be made port-independent in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.