[Webkit-unassigned] [Bug 66963] [Chromium] Move untrusted HTTP method/header checking to AssociatedURLLoader.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66963





--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-25 14:57:55 PST ---
(From update of attachment 105224)
View in context: https://bugs.webkit.org/attachment.cgi?id=105224&action=review

>> Source/WebKit/chromium/public/WebURLLoaderOptions.h:45
>> +      : untrustedHttp(false)
> 
> Need 4 space indent.

nit: untrustedHttp -> untrustedHTTP

see webkit style guide where it mentions capitalization rules for acronyms.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:58
> +class SafeHttpHeaderValidator : public WebHTTPHeaderVisitor {

nit: SafeHttp -> SafeHTTP

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:282
> +        m_clientAdapter->didFail(ResourceError());

maybe we should have a setDelayedError method to make it more explicit what
we are doing here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.