[Webkit-unassigned] [Bug 57731] [CSS 3] missing cursor support for 'none' on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57731





--- Comment #14 from Adam Roben (:aroben) <aroben at apple.com>  2011-08-25 08:33:24 PST ---
(In reply to comment #13)
> Created an attachment (id=104642)
 --> (https://bugs.webkit.org/attachment.cgi?id=104642&action=review) [details]
> Revised patch addressing comments.
> 
> Updated patch to address comments. It was simple to add an ASSERT for WebKit, but I ended up not doing an ASSERT for WebKit2 for the following reasons:
> 1. Not asserting and just returning without setting the cursor was closer to how the code worked before this patch, so it seems less risky.
> 2. I noticed that WebView::cursorToShow returns 0 if the page isn't valid, which may be the case even if the WebCore cursor's Type isn't None. I figured it would be better to continue with DefWindowProc's cursor handling rather than asserting.

I think it would still be good to assert, even if we also bail out in Release builds. We'll just have to take the page's validity into account.

> With this method of implementing cursor: none, the convention of a null override cursor meaning "don't use an override" won't work if the override cursor itself ever needs to be 'none'. Is this a case that we need to handle?

I don't think we need to handle that case currently. (This is already something we don't support.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.