[Webkit-unassigned] [Bug 66661] Replace some usages of Vector<UChar> to StringBuilder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 24 23:45:32 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66661


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-08-24 23:45:32 PST ---
Attachment 105137 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:37:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
Source/WebCore/editing/MarkupAccumulator.h:115:  The parameter name "entityMask" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/editing/markup.cpp:136:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/tests/StringBuilderTest.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/tests/StringBuilderTest.cpp:51:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebCore/css/CSSOMUtils.h:48:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/rendering/InlineTextBox.h:40:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/chromium/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/xml/parser/MarkupTokenBase.h:81:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 11 in 77 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list