[Webkit-unassigned] [Bug 66081] The "port" property of an <a> whose href does not specify a port returns the wrong value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66081





--- Comment #18 from Darin Adler <darin at apple.com>  2011-08-24 20:31:41 PST ---
(From update of attachment 105122)
View in context: https://bugs.webkit.org/attachment.cgi?id=105122&action=review

> Source/WebCore/page/Location.cpp:89
> -    return url.port() ? url.host() + ":" + String::number(url.port()) : url.host();
> +    return url.hasPort() ? url.host() + ":" + String::number(url.port()) : url.host();

What test covers this change?

> Source/WebCore/page/Location.cpp:206
> -    if (port < 0 || port > 0xFFFF)
> +    if (port < 0 || port > 0xFFFF || portString.isEmpty())

What test covers this change?

> Source/WebCore/platform/KURLGoogle.cpp:677
> +    portStr = String::number(i);
> +    replacements.SetPort(
> +        reinterpret_cast<const url_parse::UTF16Char*>(portStr.characters()),
> +        url_parse::Component(0, portStr.length()));

What test covers this change? That same test could verify that we don't have the bug with KURL.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.