[Webkit-unassigned] [Bug 61167] Middle clicking a named target sets a focus to a previously opened page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61167


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103222|review?                     |review-
               Flag|                            |




--- Comment #24 from Adam Barth <abarth at webkit.org>  2011-08-24 10:12:34 PST ---
(From update of attachment 103222)
View in context: https://bugs.webkit.org/attachment.cgi?id=103222&action=review

> Source/WebCore/loader/FrameLoader.cpp:198
> +    , m_navigationPolicy(NavigationPolicyCurrentTab)

Why is this a property of the loader and not of the load itself?

> Source/WebCore/loader/FrameLoader.cpp:1173
> +    m_navigationPolicy = NavigationPolicyCurrentTab;

What about all the other APIs for triggering navigations.  As you've written the patch, it seems like they're re-use whatever value m_navigationPolicy happens to be set to.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.