[Webkit-unassigned] [Bug 66720] chromium WebFrameImpl - don't load javascript URLs against chrome internal pages.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66720





--- Comment #13 from Adam Barth <abarth at webkit.org>  2011-08-24 10:05:32 PST ---
(From update of attachment 104860)
View in context: https://bugs.webkit.org/attachment.cgi?id=104860&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This line will prevent this change from landing.  You should replace it with a line that says you wrote a Chromium WebKit API unit test.

> Source/WebCore/ChangeLog:9
> +

It would be nice to put some more explanation in the ChangeLog as to why we're making this change and whether we think this registry is useful for WebCore's JavaScript URL implementation.

> Source/WebCore/platform/SchemeRegistry.cpp:107
> +static URLSchemesMap& notAllowingJavascriptURLsSchemes()

This name seems slightly tortured, but I can see how it fits the pattern.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.