[Webkit-unassigned] [Bug 36256] shift+click to extend a wordgranularity selection backwards selects the space after

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36256





--- Comment #4 from Van Lam <vanlam at google.com>  2011-08-24 10:01:24 PST ---
(In reply to comment #2)
> (From update of attachment 104955 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104955&action=review
> 
> > Source/WebCore/editing/VisibleSelection.cpp:300
> > +            if (isEndOfDocument(originalEnd) || (isEndOfLine(originalEnd) && !isStartOfLine(originalEnd) && !isEndOfParagraph(originalEnd)) || (isEndOfWord(originalEnd) && start != originalEnd && m_extent != originalEnd))
> 
> I'd split it into two lines since this is really long line.  ap & mitz should probably look at this change.
> 
> > Source/WebCore/editing/visible_units.cpp:288
> > +    if (c.isNull())
> > +        return false;
> > +    
> > +    VisiblePosition prev = previousWordPosition(c);
> > +    return prev.isNotNull() && endOfWord(prev, RightWordIfOnBoundary) == c;
> 
> So we can't just do endOfWord(c, RightWordIfOnBoundary) == c ?

No, if c is at the end of a word, endOfWord(c, RightWordIfOnBoundary) returns the end of the following word.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.