[Webkit-unassigned] [Bug 66851] Fix CSSPrimitiveValue::cssText() to use StringBuilder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66851





--- Comment #3 from Darin Adler <darin at apple.com>  2011-08-24 09:50:27 PST ---
(From update of attachment 104982)
View in context: https://bugs.webkit.org/attachment.cgi?id=104982&action=review

Thanks for tackling this. I see no reason to overload the += operator, though. Lets use append.

> Source/JavaScriptCore/wtf/text/StringBuilder.h:57
> +    inline void operator+=(const String& string)

Why is it critical to use += instead of an append function? Just to keep the editing down?

> Source/WebCore/css/CSSPrimitiveValue.cpp:646
> +            text += formatNumber(m_value.num);
> +            text += "em";

I think these would read better as append function calls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.