[Webkit-unassigned] [Bug 59064] [GTK] Support EGL backend for WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59064





--- Comment #25 from Martin Robinson <mrobinson at webkit.org>  2011-08-24 09:01:42 PST ---
(From update of attachment 103441)
View in context: https://bugs.webkit.org/attachment.cgi?id=103441&action=review

It looks good to me in general, but I still would like a nod from someone more familiar with GraphicsContext3DOpenGL.cpp.

> Source/WebCore/ChangeLog:11
> +        Add build-flags like WTF_USE_GLX & WTF_USE_EGL to seperate gl-backends.
> +        Almost GL common APIs in GraphicsContext3DOpenGL.cpp are moved to GraphicsContext3DBase.cpp
> +        And the others APIs needed to seperate according to gl-backend are located at GraphicsContext3DOpenGL.cpp and GraphicsContext3DOpenGLES.cpp.
> +        Some GL extention parameters which are not defined in GLES are added newly in OpenGLShims.h

Do you mind evening out the ChangeLog lines here?

> Source/WebCore/platform/graphics/cairo/OpenGLShims.cpp:122
> +    openGLFunctionTable()->glBlitFramebuffer = ::glBlitFramebufferANGLE;

Why was this change necessary?

> Source/WebCore/platform/graphics/cairo/OpenGLShims.h:54
> +#if !defined(GL_FRAMEBUFFER_EXT)
> +#define GL_FRAMEBUFFER_EXT GL_FRAMEBUFFER
> +#endif
> +#if !defined(GL_COLOR_ATTACHMENT0_EXT)
> +#define GL_COLOR_ATTACHMENT0_EXT GL_COLOR_ATTACHMENT0
> +#endif
> +#if !defined(GL_RENDERBUFFER_EXT)
> +#define GL_RENDERBUFFER_EXT GL_RENDERBUFFER
>  #endif
> +#if !defined(GL_STENCIL_ATTACHMENT_EXT)
> +#define GL_STENCIL_ATTACHMENT_EXT GL_STENCIL_ATTACHMENT
> +#endif
> +#if !defined(GL_DEPTH_ATTACHMENT_EXT)
> +#define GL_DEPTH_ATTACHMENT_EXT GL_DEPTH_ATTACHMENT
> +#endif
> +#if !defined(GL_FRAMEBUFFER_COMPLETE_EXT)
> +#define GL_FRAMEBUFFER_COMPLETE_EXT GL_FRAMEBUFFER_COMPLETE
> +#endif
> +#endif // End of GL_ES_VERSION_2_0

Should these lines be EGL only or is it safe to enable them for normal GL as well?

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:36
> +#if PLATFORM(GTK)
> +#include "OpenGLShims.h"
> +#endif

This should be in a separate block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.