[Webkit-unassigned] [Bug 66800] [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66800





--- Comment #12 from Steve Block <steveblock at google.com>  2011-08-24 07:34:59 PST ---
(From update of attachment 104995)
View in context: https://bugs.webkit.org/attachment.cgi?id=104995&action=review

LGTM, but please get a Chromium reviewer to take a look before I r+.

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:427
> +        ASSERT_NOT_REACHED();

I think it's Chromium policy to have code to gracefully fail after an ASSERT_NOT_REACHED(), as these don't cause a crash in release builds.

> Source/WebKit/chromium/src/WebInputEventConversion.h:126
> +// NOTE: WebTouchEvents have a cap on number of WebTouchPoints. Any points

'has a cap on the'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.