[Webkit-unassigned] [Bug 66800] [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66800





--- Comment #10 from Steve Block <steveblock at google.com>  2011-08-24 06:58:31 PST ---
(From update of attachment 104988)
View in context: https://bugs.webkit.org/attachment.cgi?id=104988&action=review

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:304
> +    timeStampSeconds = event.timeStamp() / MILLIS_PER_SECOND;

event.timeStamp() is an integer value, right, so you need to make MILLIS_PER_SECOND a floating-point value to force floating-point division.

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:397
> +    unsigned int maxWebTouches = static_cast<unsigned int>(WebTouchEvent::touchesLengthCap);

Any reason WebTouchEvent::touchesLengthCap isn't unsigned? Also, maybe add a comment here or at WebTouchEvent::touchesLengthCap that we limit the max number of touches and simply drop extra touches on the floor.

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:399
> +                                maxWebTouches : touches->length());

I think there's a min() macro you can use.

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:429
> +        type = Undefined;

Add ASSERT_UNREACHED()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.