[Webkit-unassigned] [Bug 66852] New: [Qt] [PATCH] Improve the handling of $project in webkitdirs.pm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66852

           Summary: [Qt] [PATCH] Improve the handling of $project in
                    webkitdirs.pm
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: freebsd at chillt.de
                CC: abecsi at webkit.org


Created an attachment (id=104983)
 --> (https://bugs.webkit.org/attachment.cgi?id=104983&action=review)
Patch implementing the proposed improvements

The buildQMakeProject() method in Tools/Scripts/webkitdirs.pm takes a project type as its first parameter. Analogously to the Gtk port's buildGtkProject(), two project types are supported:

* build-webkit uses project type "WebKit"
* build-jsc uses project type "JavaScriptCore"

There are a number of bugs and hacks in the way these project types are handled and evaluated. The attached patch cleans up the handling a bit. The following changes are made:

* A FIXME in build-webkit is addressed by correctly passing "WebKit" instead of "Source/WebKit" as the project type
* The buildQMakeQtProject() method is retired whose only purpose was to sabotage the project type by replacing it with ""
* The handling of the project type in buildQMakeProject() is simplified, reducing it to what is needed for the two project types above only

In addition to the above improvements, buildQMakeQtProject() can be instructed to build the libraries ("JavaScriptCore", "WebCore", "WebKit/qt/Api") only by leaving the project type blank. Tools and examples are omitted from the build in this case. This is useful under e.g. FreeBSD where the Tools depend on an installed version of the Qt WekBit port, leading to circular dependencies.

I have tested this patch by checking that the following work:
* build-jsc -> builds JavaScriptCore only
* build-webkit -> buildQMakeQtProject, Tools, examples
* build-webkit with project type set to "" in the call to buildQMakeQtProject() -> buildQMakeQtProject only

The issues addressed and the general idea of the patch were discussed on #qtwebkit with bbandix who is CC'd on this bug report.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.