[Webkit-unassigned] [Bug 66842] [WebSocket] Terminate existing WebSocket server before launch new one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66842





--- Comment #5 from Yuta Kitamura <yutak at chromium.org>  2011-08-24 04:21:57 PST ---
(In reply to comment #4)
> run-webkit-websocketserver kicks new-run-webkit-websocketserver internally.
> But, in my local trial, the second run-webkit-websocketserver could not kill the first one.
> 
> For example,
> 1. run-webkit-websocketserver in terminal A
> 2. run-webkit-websocketserver in terminal B
> 3. hit enter to stop the server in terminal A
> 4. nobody listen at 8880

It actually does.

1. A new pywebsocket process (PID=X) is up.
2. run-webkit-websocketserver kills the existing server (PIX=X), and starts a new one (PID=Y).
3. The new server (PID=Y) is get killed, because pidfile is overwritten in step 2.

So in this case, the problem is in step 3. I don't think your patch fixes this.

> 
> run-webkit-httpd also has a similar killing code.

Libraries under webkitpy already take care of it. You shouldn't touch this perl script.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.