[Webkit-unassigned] [Bug 36256] shift+click to extend a wordgranularity selection backwards selects the space after

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36256





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-23 23:19:03 PST ---
(From update of attachment 104955)
View in context: https://bugs.webkit.org/attachment.cgi?id=104955&action=review

> Source/WebCore/editing/VisibleSelection.cpp:300
> +            if (isEndOfDocument(originalEnd) || (isEndOfLine(originalEnd) && !isStartOfLine(originalEnd) && !isEndOfParagraph(originalEnd)) || (isEndOfWord(originalEnd) && start != originalEnd && m_extent != originalEnd))

I'd split it into two lines since this is really long line.  ap & mitz should probably look at this change.

> Source/WebCore/editing/visible_units.cpp:288
> +    if (c.isNull())
> +        return false;
> +    
> +    VisiblePosition prev = previousWordPosition(c);
> +    return prev.isNotNull() && endOfWord(prev, RightWordIfOnBoundary) == c;

So we can't just do endOfWord(c, RightWordIfOnBoundary) == c ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.